patternfly / patternfly/patternfly-react
BackgroundImage - full page cover variant with theme support
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Follow-up to https://github.com/patternfly/patternfly/issues/8350
Add new variant for full page BackgroundImage.
Add new prop for per-theme background overrides:
light-default
dark-default
light-felt
dark-felt
HC-light-default
HC-dark-default
HC-light-felt
HC-dark-felt
light-glass
dark-glass
light-felt-glass
dark-felt-glass
Could be a follow up - update Compass examples to use BackgroundImage instead of setting background image via style on html.
Jira Issue: PF-4078
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing BackgroundImage component and the requirements in follow-up issue #8350. Determine how the full-page cover variant and per-theme overrides fit the current API, then check the Compass examples that currently set the background on html. Done means the new variant and listed theme overrides work, with Compass updated if that follow-up is included.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100