patternfly / patternfly/patternfly-react
[Spike] - investigate friendly names for all icon sets
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Instead of needing to have prefixed icons e.g. "RhUiArrowDownIcon" and "RhMicronArrowDownIcon" and "ArrowDownIcon", see how feasible it is to create a single "ArrowDownIcon" that has an additional "set" property to control which source path data is rendered.
Should be possible in the writeIcons script before exporting everything, just need to be careful in mapping everything and ensure that icons are named consistently (no arrow-down and down-arrow icons because they would be mapped differently). Need to determine a fallback order for sets (pf/fa > rh-ui > rh-microns > etc?) and default set. Need to figure out documentation because not all icons will have support or data for all sets, and icons may have different default sets.
Jira Issue: PF-3403
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the writeIcons script named in the issue and trace how icon names and source paths are mapped before export. Evaluate consistent name mapping, set selection, fallback order, and default behavior, then document feasibility, unsupported set combinations, and the resulting API decisions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100