patternfly / patternfly/patternfly-react
Bug - FormSelect - Accessibility warning doesn't check `aria-labelledby`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the problem
When using FormSelect with a prop aria-labelledby that points to another label it will complain that the component requires either an ID or aria-label to be specified. Specifically:
FormSelect requires either an id or aria-label to be specified
How do you reproduce the problem?
- Go to https://codesandbox.io/p/sandbox/zk38dy
- Open console
- See
FormSelect requires either an id or aria-label to be specified
Expected behavior
FormSelect also checks aria-labelledby before showing the warning.
Is this issue blocking you?
No
Jira Issue: PF-2918
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the FormSelect component and the accessibility warning that reports a missing id or aria-label. Reproduce the issue with the linked CodeSandbox, then verify that providing aria-labelledby no longer triggers the warning while the existing warning behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100