patternfly / patternfly/patternfly-react

Bug - [ToolbarFilter] - [the "clear all filters" button is not on the same row as filter labels]

Open
#11,982 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the problem
A clear and concise description of the problem. Which components are affected?
https://www.patternfly.org/components/toolbar
Toolbar component
How do you reproduce the problem?
Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.

When the filters from ToolbarFilter are created and added to the toolbar, they automatically create "Clear all filters" button. This button is pushed down below the filter labels. It should be on the same row.

The documentation show this issue
https://www.patternfly.org/components/toolbar#with-custom-label-group-content

Expected behavior
Clear all filters button is on the same row as filter labels

Is this issue blocking you?
I have a UI I am working on, and it's a requirement in my UX mocks.

Screenshots
If applicable, add screenshots to help explain the issue.

image

What is your environment?

  • OS: [e.g. iOS]

  • Browser [e.g. chrome, safari]

  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?


Jira Issue: PF-2594

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ToolbarFilter component and the custom label group content example in the linked PatternFly documentation, then reproduce the layout using the provided CodeSandbox. Check how the filters and "Clear all filters" button are arranged, and verify that the button stays on the same row as the filter labels.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.