patternfly / patternfly/patternfly-react
MenuToggle - add aria-invalid and aria-autocomplete
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the enhancement or change
Per https://github.com/patternfly/patternfly/issues/6562#issuecomment-2839684312:
-
MenuToggle should be updated to apply
aria-invalid="true"when the status is danger for non-typeahead/plain toggles (basic toggles and split button toggles). If there are any typeahead examples showing status, those should be updated to apply the aria-invalid to the input element. -
For typeahead variants, examples and templates should be updated so that
aria-autocomplete="list"is applied to the text input being used as the typeahead input.
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
Any other information?
Jira Issue: PF-1732
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the MenuToggle component, its examples, and templates, focusing on basic, split-button, and typeahead variants. Update the relevant rendered elements so danger status exposes aria-invalid and typeahead inputs expose aria-autocomplete="list"; done means the examples and component behavior reflect these attributes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100