patternfly / patternfly/patternfly-react

Drawer - Refine Drawer Usage for Better Integration with External Components

Open
#11,804 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Stale
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the problem

This arose from fixing a layout bug with the drawer component in PR #4142.

Using DrawerPanelContent within an externally provided DrawerPanelContent (in this case from PF Topology) breaks the layout of the sidebar panel.

  • Addressed by removing the nested DrawerPanelContent and directly applying DrawerHead and DrawerPanelBody within the DrawerPanelContent that is externally provided from TopologyView.

In our use case, the utility class pf-v6-u-p-md was applied to get the same padding, but this workaround highlights a gap in the current implementation.

How do you reproduce the problem?

See https://github.com/opendatahub-io/odh-dashboard/pull/4142.

Expected behavior

PatternFly needs an improved way to structure and compose standard drawer elements like DrawerHead and DrawerPanelBody within an external DrawerPanelContent wrapper from the TopologyView.

Is this issue blocking you? No.

What is your product and what release date are you targeting?
RHOAI

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with PR #4142 and the TopologyView usage of an externally provided DrawerPanelContent. Read how DrawerHead and DrawerPanelBody are composed within the drawer components, then reproduce the sidebar layout scenario. Done means standard drawer elements integrate with the external wrapper without the nested-content workaround or manual padding class.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.