patternfly / patternfly/patternfly-react

Page - update logic to apply sidebar-less layout

Open
#11,797 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Breaking change :boom: PF Team
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the enhancement or change
Followup to https://github.com/patternfly/patternfly-react/pull/11760 where we apply logic to apply a modifier class for sidebar-less layout if sidebar={null} (tldr reason being to avoid breaking consumers who may rely on sidebar being explicitly undefined, but want to keep the layout as-is).

We want to update the logic in the next breaking change so that omitting the sidebar prop (or it otherwise being falsey) will apply this modifier class instead of having to explicitly pass null to the prop.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the sidebar-less layout logic in the Page component and the behavior introduced by pull request #11760. Trace how omitted, falsey, and explicitly null sidebar props are handled, then verify that the modifier class is applied for the intended cases without breaking existing consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.