patternfly / patternfly/patternfly-react
Alert - remove hasAnimations prop during breaking change
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the enhancement or change
Followup to animations PR https://github.com/patternfly/patternfly-react/pull/11495 where hasAnimations was added as beta, with the intent being it'd be used for testing purposes only. In the next breaking change we would expect consumers to update tests to reflect animations within an AlertGroup and should remove the prop.
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
Any other information?
Jira Issue: PF-2207
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing hasAnimations in the AlertGroup component and its tests, using animations PR #11495 as context. Remove the beta prop during the breaking change and update the related tests so their expected AlertGroup animation behavior matches the new API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100