patternfly / patternfly/patternfly-react
DataList - Rename aria-labelledby Prop in DataListItem
Open
Nobody has claimed this yet.
Breaking change :boom:
PF Team
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
This is a followup to #11569
Currently, aria-labelledby is being used to provide an accessible name to the selectable input when one is rendered. To improve clarity and align with its actual purpose, we should rename this prop to selectableInputAriaLabelledby
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the DataListItem component and find its current aria-labelledby prop, then read issue #11569 for the follow-up context. Rename the prop to selectableInputAriaLabelledby and update its usages; done means the selectable input still receives its accessible name through the clearer prop.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100