patternfly / patternfly/patternfly-react
Bug - [Pagination] - ofWord insufficient for internationalization
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the problem
The pagination ofWord prop simply sticks that word in the phrase (e.g. "1 – 2 of 2"), but this word order is incorrect/incomplete in some languages.
For example, in Chinese, "1 - 2 的 2" should be "2 的 1 - 2"; instead of "1 的 1 页" it should be "1 页的 1".
Is this issue blocking you?
One possible workaround is to define our own ToggleTemplate instead of the one provided by PF. See https://github.com/ansible/ansible-hub-ui/pull/3248/files#diff-557f73ee26e47e81e8822500a443d62d86428cfe044435601c719fee5b22d43dR33
What is your product and what release date are you targeting?
AAP (longstanding issue)
Jira Issue: PF-2204
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PatternFly React pagination component's ofWord prop and the ToggleTemplate workaround linked in the issue. Compare the current phrase assembly with the Chinese examples, then identify the component's existing internationalization and test entry points; done means the pagination wording supports language-specific word order without requiring a custom template.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, internationalization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100