patternfly / patternfly/patternfly-react

Bug - DragDropSort - DataListControl is duplicated when used in a Table/Modal

Open
#11,312 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

PF Team Stale
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

From https://github.com/patternfly/patternfly-react/pull/11295

When DragDropSort is used in the table column management demo, the content of the draggable DataList items that DragDropSort creates internally somehow is double wrapping with DataListControl.

This may be a demo issue or issue with DragDropSort.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the table column management demo from the context of PR #11295, using DragDropSort inside a Table/Modal. Compare whether the duplicated DataListControl comes from the demo usage or from DragDropSort's internally created draggable DataList items. Done means the draggable items render without double-wrapped DataListControl content.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.