patternfly / patternfly/patternfly-react
Card: Combine isCompact and isLarge into one prop
Open
Nobody has claimed this yet.
Breaking change :boom:
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the enhancement or change
Combine isCompact and isLarge into one prop since only one can be applied at a time. Then we can remove console warning.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Locate the Card component entry point, inspect how isCompact and isLarge are defined and where the console warning is emitted, then verify that the combined prop replaces both options and the warning is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100