Tip admonition block style is not applied correctly in v5
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with packages/module/src/ConsoleShared/src/components/markdown-extensions/admonition-extension.tsx at line 20 and reproduce the TIP syntax from the issue using PatternFly 5. Compare the rendered result with the Alert custom variant documentation. Done means the TIP admonition displays the expected custom styling.
Written by the indexing model from the issue text.
Description
Description
When I use the following syntax for an admonition block with TIP variant.
[This is the tip contents]{{admonition tip}}
The block is displayed but its style is incorrect. I expect it to have "custom" variant style as in this doc: https://www.patternfly.org/components/alert#alert-variants.
| What I expect to see | What I saw instead |
|---|---|
Environment
Using v5.3.0 with Patternfly 5.
"@patternfly/quickstarts": "^5.3.0",
"@patternfly/react-catalog-view-extension": "^5.0.0",
"@patternfly/react-charts": "^7.3.0",
"@patternfly/react-core": "^5.3.4",
"@patternfly/react-icons": "^5.3.2",
"@patternfly/react-styles": "^5.3.1",
"@patternfly/react-table": "^5.3.4",
"@patternfly/react-topology": "^5.2.0",
Others
I think a quick fix would be to set the variant of the TIP admonition to custom or simply unset it. See below:
Reference: https://www.patternfly.org/components/alert#alert
- Dominant language
- TypeScript
- Stars
- 15
- Forks
- 47
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from patternfly/patternfly-quickstarts
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
PF Team
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
PF Team
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
All issues in patternfly/patternfly-quickstarts
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
0xMiden/bridge-portal#132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:tools bug good first issue help wanted priority:P2
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
TaewoooPark/Motifcode#14 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
newrelic-experimental/preflight#793 · 1 comment ·