patternfly / patternfly/patternfly-org
MenuToggle - Update a11y docs to include mention dynamic toggle label + aria attributes
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 74
- Forks
- 147
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 2
Description
Per https://github.com/patternfly/patternfly/issues/6562#issuecomment-2839684312, we should update MenuToggle a11y docs to mention that when the toggle content is expected or intended to be dynamic (such as when used for a Select, where a selected option might become the toggle content), there should also be a static label for the toggle.
Additionally, we should mention when aria-invalid="true" and aria-autocomplete="list" should be applied (the former whenever status is danger, the latter for typeahead toggles only)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MenuToggle accessibility documentation and review the guidance referenced by issue 6562. Update the documentation to cover a static label for dynamic toggle content and when aria-invalid="true" and aria-autocomplete="list" apply. Done means all three cases are clearly documented in the relevant MenuToggle a11y section.
Written by the indexing model from the issue text.
Assessment
- Domain
- accessibility, documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100