patternfly / patternfly/patternfly-org

Bug - SVGs - assets svg imports resulting in ModuleNotFound error

Open
#3,757 1 comment 0 reactions 1 assignee View on GitHub

@jenny-s51 is already working on this.

Since Sep 22, 2023.

Dominant language
JavaScript
Stars
74
Forks
147
Avg merge
4d 11h
Merged PRs (30d)
2

Description

Describe the problem
A clear and concise description of the problem. Which components are affected?

Noted in patternfly/patternfly-react#9140 - moving 1 - 3 to a separate issue as this is out of scope from CodeSandbox and requires more investigation as to why the svgs are not found. @Dominik-Petrik is also running into this issue in his conversion effort for patternfly/patternfly-react#9553 .

Could not find module in path: '@patternfly/react-core/src/demos/assets/pf-logo-small.svg' relative to '/index.tsx'
  1. Icon import paths in Primary Detail Card View demo are not correct and CodeSandbox demo does not render the icons correctly

  2. Masthead fullscreen demo - imgAvatar and pfIcon not rendering correctly in CodeSandbox

  3. Application Launcher - demos that import pfLogoSm not rendering PF icons within dropdown items in CodeSandbox


Jira Issue: PF-1965

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.