patrickhulce / patrickhulce/third-party-web
In entities.js, should Facebook and Instagram have a company field
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 112
- Avg merge
- 22h 26m
- Merged PRs (30d)
- 1
Description
File URL: https://github.com/patrickhulce/third-party-web/blob/master/data/entities.js
I noticed that of the 2119 entities, only 424 have a company field. Maybe it would be useful if the ones that belong to the same company had a matching company field, at least for the biggest companies. I could add company: 'Meta' to the Facebook and Instagram entities.
There’s also a big list of Facebook/Meta domains in the contain-facebook repo, but I didn’t find any of the other domains in entities.js.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with data/entities.js and inspect the Facebook and Instagram entity records, then compare the related domain list in contain-facebook/src/background.js. Determine which entities are in scope for a shared company value and update the data consistently; done means the intended Facebook/Meta entities have matching company fields without unrelated changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100