patrickhulce / patrickhulce/third-party-web

Highlight third parties with unload event handlers?

Open
#185 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.1k
Forks
112
Avg merge
22h 26m
Merged PRs (30d)
1

Description

Would it be possible to highlight third parties that still rely on unload event handlers?

Those break the back/forward cache on some browsers, and are unreliable on other browsers or mobile platforms.
There are better alternatives available which don't have these downsides (e.g. visibilitychange).
More details in this lighthouse issue.

We did a large outreach to increase awareness and successfully convince lots of third parties to migrate away from unload event handlers, but there is still a long tail of third parties... Perhaps, thirdpartyweb could help raise awareness at scale?

Here is a query that should give a list of unload event handler sources:

SELECT COUNT(*) AS CNT, unload_source, unload_line, unload_column 
FROM `httparchive-lighthouse.BestPractices.unload_sources`
GROUP BY unload_source, unload_line, unload_column 
ORDER BY CNT DESC LIMIT 1000;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The payload names no repository files, tests, or entry points. Start by reviewing the linked Lighthouse issue and running the supplied BigQuery query; before implementation, define where third parties with unload handlers should be highlighted and what output demonstrates completion.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, sql
Domain
analytics, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.