patrick-kidger / patrick-kidger/diffrax
Adjust dense output when using `HalfSolver`.
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 189
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 1
Description
At the moment this is using the dense_info from the larger step but advancing the solution using the two smaller steps:
But these two values needn't line up, so the resulting collection of dense_infos will define something with slight discontinuities in between steps.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at diffrax/solver/base.py around line 241 and inspect how HalfSolver advances the solution and collects dense_info. Compare the dense output from the larger step with the two smaller steps; done means the resulting dense output is continuous between steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100