patrick-kidger / patrick-kidger/diffrax
Specification of sign change direction
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 189
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 1
Description
Hi diffrax team,
I feel like it would be a nice addition to the current Events, if it was possible to specify the direction of the sign change of the cond_fn that triggers an event and choose between unidirectional (lets say positive to negative) or bidirectional (as it is now). Doesn't have super high prio for me atm but thought i'll throw it in here.
What do you think? If thats useful and you think its easy to do I could have a look how to get that working.
Thanks for the help :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names Events and cond_fn but does not identify a file or test. Trace the existing event and sign-change handling from those entry points, then check how event behavior is tested. Done means supporting a selectable positive-to-negative direction while preserving the current bidirectional behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100