patrick-kidger / patrick-kidger/diffrax
Problem for adding gradient penalty into sde-gan
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 189
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 1
Description
Hi Patrick,
Firstly, I applaud the excellent paper: Neural SDEs as Infinite-Dimensional GANs.
According to your paper, I am trying to add gradient penalty into your code: /examples/neural_sde.ipynb .
# x_hat through interpolation
interps = epsilon * ys_i + (1 - epsilon) * fake_ys_i
# E_D(x_hat)
def loss_x_(discriminator, ys, ts):
return dis(ts, ys).mean()
# gradient penalty function
def grad_penalty(discriminator, ys, ts):
loss_grad = jax.grad(loss_x_, argnums=1)(discriminator, ys, ts)
grad_norm = jnp.sqrt(jnp.sum(loss_grad ** 2))
return jnp.mean((grad_norm - 1.0) ** 2)
# gradient penalty
gradient_penalty = eqx.filter_grad(grad_penalty)(discriminator, interps, ts_i)
But after my debugging, I found that eqx.filter_grad doesn't seem to accept jax.grad.
I'm a newbie to jax and there's nothing I can do about this. I would be grateful if you could give me some ideas.
Last, Error show:
ValueError: Reverse-mode differentiation does not work for lax.while_loop or lax.fori_loop with dynamic start/stop values. Try using lax.scan, or using fori_loop with static start/stop.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with /examples/neural_sde.ipynb and reproduce the shown ValueError from the gradient-penalty code using eqx.filter_grad and jax.grad. Trace the nested differentiation through the notebook's SDE solver path; done means the gradient-penalty example either runs successfully or the incompatibility and required change are documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100