patrick-kidger / patrick-kidger/diffrax
Find a way to remove `AbstractStepSizeController.wrap`
Open
Nobody has claimed this yet.
refactor
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 189
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 1
Description
It's a bit of a wart, used only for passing direction.
Likewise for AbstractStepSizeController.wrap_solver.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the usages of AbstractStepSizeController.wrap and AbstractStepSizeController.wrap_solver, focusing on how they pass direction. Determine whether both wrappers can be removed without changing solver behavior; done means their callers no longer depend on these methods and the existing solver behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100