patrick-kidger / patrick-kidger/diffrax
Revisit wrapped solvers
Open
Nobody has claimed this yet.
next
refactor
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 189
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 1
Description
These don't really work properly at the moment. For example
class MySolver(AbstractWrappedSolver):
...
diffeqsolve(solver=MySolver(Kvaerno3()), stepsize_controller=PIDController(...), ...)
does not work because MySolver doesn't have a nonlinear_solver attribute for the PIDController to apply its rtol and atol to.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing AbstractWrappedSolver through diffeqsolve and PIDController, using the MySolver(Kvaerno3()) example as the reproduction case. Determine how wrapped solvers should expose or handle the nonlinear solver settings, then verify that PIDController can apply rtol and atol without a missing nonlinear_solver attribute.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100