parse-community / parse-community/parse-server

Add CI check to ensure no devDependency is required in production

Open
#7,796 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:ci
Dominant language
JavaScript
Stars
21.4k
Forks
4.8k
Avg merge
7h 45m
Merged PRs (30d)
11

Description

New Feature / Enhancement Checklist
Current Limitation

The CI currently installs all dependencies including devDependendies, which are required to run tests. Therefore, if a dependency is required for a production deployment, but has accidentally been added to devDependendies instead of dependendies, the CI cannot not detect that and Parse Server may crash in a production deployment.

Feature / Enhancement Description

Add CI check that ensures all dependencies that are required for a production deployment are added in under dependendies and none of the devDependendies is required.

Maybe a tool like https://www.npmjs.com/package/dependency-check can make this easy to implement.

Example Use Case

See issue https://github.com/parse-community/parse-server/issues/7786

Alternatives / Workarounds
  • manually ensure during review that prod dependency is not added to dev dependency

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the repository's CI configuration and package dependency declarations, then compare the current installation with a production-only installation. The check is done when CI detects any production-required dependency placed in devDependencies, using issue 7786 as the example case if needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.