parse-community / parse-community/parse-server
node-forge used as phantom dependency in gcenter.js
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 21.4k
- Forks
- 4.8k
- Avg merge
- 7h 45m
- Merged PRs (30d)
- 11
Description
New Issue Checklist
- Report security issues confidentially.
- Any contribution is under this license.
- Before posting search existing issues.
Issue Description
When upgrading a different packaged that used to hoist node-forge we experienced a failure since node-forge is not declared in package.json but imported in gcenter.js. We solved it by hoisting it ourselves, but it should be installed as a dependency on parse-server.
Steps to reproduce
Install parse-server without having a hoisted node-forge installed.
Actual Outcome
Failure due to node-forge not being installed.
Expected Outcome
node-forge being installed automatically.
Environment
Server
- Parse Server version: 8.6.72
- Operating system: MacOS
- Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the node-forge import in gcenter.js and the dependency declarations in package.json. Reproduce the issue by installing parse-server without a hoisted node-forge, then verify that a fresh installation provides the dependency automatically.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend, build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100