parse-community / parse-community/parse-server-push-adapter
if no deviceToken, count is never decremented fully, and the PushStatus never marked success/fail
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 96
- Forks
- 108
- PR merge metrics
- No merged PRs in 30d
Description
if I have no deviceToken assigned, and send a push to that Installation,
then in PushAdapterUtils.classifyInstallations:
// No deviceToken, ignore
if (!installation.deviceToken) {
continue;
}
completely shortcuts any attempted execution of push to these devices.
this is fine, but because the push is never sent, no response from the push service can decrement the count,
so it never completes, and PushStatus is left in a 'running' state with outstanding count equal to the number of null deviceToken records.
somewhere here, this needs to either drop the total count, or decrement the oustanding count,
or just drop the if/continue altogether.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in PushAdapterUtils.classifyInstallations and trace how installations without a deviceToken affect the outstanding count and PushStatus updates. Reproduce the no-deviceToken case, then verify that the push reaches a terminal success or failure state with no outstanding count remaining.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100