paritytech / paritytech/try-runtime-cli

Remove DB operations in async code

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
25
Forks
29
PR merge metrics
No merged PRs in 30d

Description

          you don't have to do it in this PR but worth investing whether it makes things faster or not.

Ideally, we shouldn't do any DB operations in async code it might fuckup the async scheduler in tokio

Originally posted by @niklasad1 in https://github.com/paritytech/substrate/pull/14057#discussion_r1181570805

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the asynchronous code paths and their database operations in the try-runtime-cli repository, then determine how those operations interact with the Tokio scheduler. The issue provides no file or test entry point, so first map the affected code and establish how to verify scheduler safety. Done means the relevant async paths avoid database operations without changing their intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain, databases
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.