paritytech / paritytech/triangle-js-sdks

getNonProductAccountSigner requires a ProductAccount

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
3
Forks
1
Avg merge
1d 14h
Merged PRs (30d)
8

Description

getNonProductAccountSigner(account: ProductAccount): PolkadotSigner;

This signature doesn't make sense because it requires a ProductAccount

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the declaration and call sites for getNonProductAccountSigner, then inspect the account types used by those callers. Confirm which account type the function should accept; done means the public signature no longer requires ProductAccount and the relevant type checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.