paritytech / paritytech/triangle-js-sdks

missing type re-exports

Open
#25 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug team: parity-product
Dominant language
TypeScript
Stars
3
Forks
1
Avg merge
1d 14h
Merged PRs (30d)
8

Description

Some types like SignerPayloadJSON are declared in the public API but are not re-exported

https://github.com/Polkadot-Community-Foundation/triangle-js-sdks/blob/693c3398a0b51ae0e1bef02c6d6e02906422dc1a/packages/product-sdk/src/injectWeb3.ts#L5-L26

I'd recommend setting something up like a d.ts rollup to avoid these issues. Happy to help on this as well

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/product-sdk/src/injectWeb3.ts at the linked lines and inspect how its public types are declared and exported. Check the generated package declarations to identify missing re-exports and assess the proposed d.ts rollup. Done means public types such as SignerPayloadJSON are available from the package API without importing internal files.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.