paritytech / paritytech/subxt

`TransactionExtension`: Update naming

Open
#1,468 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
489
Forks
293
Avg merge
18h 35m
Merged PRs (30d)
3

Description

See eg https://github.com/paritytech/polkadot-sdk/pull/2280 and my comment here links to the bit showing the new encoding: https://github.com/paritytech/polkadot-sdk/pull/2280#discussion_r1481193578 (though note that the actual extrinsic version will change to 5 for the new type based on latest comments).

We've used frame-decode to suppor tthis new TX version in Subxt, but we should still:

  1. Rename our SignedExtensions to TransactionExtensions (updating the other naming around these as appropriate, eg I think "additional signed" becomes "implicit").
    2 Rename our tx client methods to match the update, eg create_unsigned becomes create_bare.
  2. Modify our existing methods to enable creating V5 extrinsics when they are supported (I think this will rely on V16 metadata to show support, and also likely on a TransactionExtension existing which allows us to add a signature.) We want to be able to create "bare" and "general" extrinsics in general, and fall back to creating V4s when V5 not supported.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Polkadot SDK pull request and its encoding discussion, then inspect Subxt's SignedExtension names and tx client methods such as create_unsigned. Trace the existing frame-decode support and V16 metadata handling. Done means the naming is updated, bare and general extrinsics can be created, and V4 remains the fallback when V5 is unavailable.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.