v0.32.1 sign_and_submit uses finalised nonce
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 489
- Forks
- 293
- Avg merge
- 18h 35m
- Merged PRs (30d)
- 3
Description
I'm not sure what 0.33.0 looks like so maybe this isn't the case there (we're not able to upgrade to 0.33.0 yet).
In 0.31.0 at least, it was the case that sign_and_submit would use the nonce from the block. However a breaking change (that's not mentioned in the release notes) was introduced which uses the nonce from the finalised block.
Waiting for finalisation means you have to wait a couple of blocks before you can submit a second transaction, I would argue that in the case of a nonce, using the unfinalised one is better, since it's going to be up to date. Was there a reason for this change?
Even if you consider the change to use finalised desirable, it would be nice to include a method that uses the unfinalised nonce - as I now have to write this manually.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sign_and_submit entry point and trace how it selects the nonce in versions 0.31.0 through 0.32.1, comparing finalized and unfinalized block behavior. Check the release history for the reported breaking change and determine whether the intended behavior is documented; done means the nonce behavior is clarified and the requested unfinalized option is either provided or explicitly ruled out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100