paritytech / paritytech/parity-scale-codec
Introduce maximum_size() to implement size_hint for set of values
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 287
- Forks
- 103
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 1
Description
When implementing size_hint for a vector or a set we don't want to iterate on all the values to actually get a hint.
One way to do so would be to have two method one taking a value size_hint(&self) and another one taking no value maxium_size().
thus they would be used as such:
- maximum_size() used on set of values
- size_hint(&self) used on individual values,
size_hint(&self) (thought maybe renamed) would default implementation to maximum_size()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name files or tests; first locate the existing size_hint implementations and callers in the Rust crate. Compare behavior for vectors, sets, and individual values, then define and validate the maximum_size/size_hint API and its resulting size hints.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100