paritytech / paritytech/parity-scale-codec
Use `Box::new_ununit` etc. once that's stabilized
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 287
- Forks
- 103
- Avg merge
- 6d 13h
- Merged PRs (30d)
- 1
Description
Once the following methods are stabilized we should take advantage of them and clean up some of the unsafe code we've added to work around the fact that these are not stable (grep for the relevant TODOs in the code):
Box::assume_init(tracking issue: https://github.com/rust-lang/rust/issues/63291)Box::new_uninitRc::new_uninitArc::new_uninitMaybeUninit::slice_assume_init_mut(tracking issue: https://github.com/rust-lang/rust/issues/63569)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
First verify that Box::assume_init, Box::new_uninit, Rc::new_uninit, Arc::new_uninit, and MaybeUninit::slice_assume_init_mut are stabilized, including the two linked Rust tracking issues. Then grep the codebase for the relevant TODOs and inspect each unsafe workaround. Done means replacing applicable workarounds with the stabilized APIs and keeping the existing codec tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100