paritytech / paritytech/parity-common
num-traits feature on primitive-types could use a FromPrimitive impl
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 311
- Forks
- 245
- PR merge metrics
- No merged PRs in 30d
Description
Types like U256 could easily impl https://docs.rs/num-traits/latest/num_traits/cast/trait.FromPrimitive.html when the num-traits feature is enabled. Happy to submit a PR adding this if you agree it would be desirable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the primitive-types crate by inspecting how the num-traits feature is defined and how types such as U256 implement related conversions. Read the num_traits FromPrimitive documentation and existing tests, then add coverage showing the implementation works when the feature is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100