paritytech / paritytech/parity-common
ethereum-types: Consider depending on uint v0.9.4 or above
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 311
- Forks
- 245
- PR merge metrics
- No merged PRs in 30d
Description
This version adds the const qualifier to some stuff (e.g. fn one). This has caused build issues in other crates, and it would be nice if it were fixed upstream (i.e. in ethereum-types crate). uint v0.9.3 and below lacks const qualifiers on certain functions.
See https://github.com/gakonst/ethers-rs/issues/2486 (with the explanation of the fix: https://github.com/gakonst/ethers-rs/issues/2486#issuecomment-1656893389)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ethereum-types crate's dependency declarations and inspect how they constrain the uint version. Compare the current requirement with uint v0.9.4, then build or test the affected crate to confirm the dependency resolves and the reported const-qualification build issue is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100