paritytech / paritytech/json-rpc-interface-spec
transaction: Change `bestChainBlockIncluded` to `Included`
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 37
- Forks
- 6
- PR merge metrics
- No merged PRs in 30d
Description
The server should report the inclusion of a transaction in any block its seeing, not only what it assumes to be the best block. Best block is any way a highly opinionated view of the server. There are several factors that can determine on what is the actual best block (e.g. on going disputes etc). Another reason why the server return Included for every block are parachains. Parachains are determining on what is the best block by checking what is the best block of the relay chain. This means currently it takes at least around 12 seconds to get any kind of feedback on your transaction. While, the transaction is probably already in a block that it just waiting to get included in the relay chain.
The most important event for dapps/wallets should be the finalized one any way, as it is then clear that the changes are not getting reverted. If we in between reported multiple blocks that included the transaction, shouldn't change anything.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the transaction status terminology around bestChainBlockIncluded, Included, and finalized, using the issue rationale about parachains as context. Update the interface specification so inclusion is reported for every containing block while finalized remains the terminal confirmation, then verify the wording is consistent across the affected status definitions.
Written by the indexing model from the issue text.
Assessment
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100