paritytech / paritytech/host-rust-core

iOS workflows pass every secret to a third-party action on a mutable tag

Open
#791 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
10
Forks
3
Avg merge
1d 10h
Merged PRs (30d)
148

Description

Several iOS workflows pass every repository secret to a third-party reusable
workflow pinned to a mutable tag.

ios-collect-prs-summary.yml:19    secrets: inherit
ios-nightly-distribution.yml:99   novasamatech/github-actions/...@v5
ios-release-distribution.yml:57   @v5
ios-build-distribute.yml:170,339  @v5

secrets: inherit hands the callee every secret this repository holds, which now
includes ASC_KEY_BASE64, MATCH_PASSWORD and the Firebase service account. The
callee is selected at run time from a tag someone outside this project can move.

This is pre-existing and predates the re-homing, but it is worth recording
because it is the one remaining way a workflow that is not held could be made to
reach Apple: the guard is on our side, the code it runs is not.

Steps
  • Pin the third-party actions to a commit SHA, as the rest of ci.yml does
  • Replace secrets: inherit with an explicit list of what each callee needs
  • Decide whether these actions should be vendored or replaced, given the
    ownership question already open on them

Found during the pre-merge review of #787. Belongs on the cutover radar rather
than in that change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ios-collect-prs-summary.yml, ios-nightly-distribution.yml, ios-release-distribution.yml, and ios-build-distribute.yml, then compare their workflow references with the SHA-pinned actions in ci.yml. Identify the secrets each reusable workflow needs and review the ownership question already open on these actions. Done means the workflows use immutable references, pass only required secrets, and have a documented decision on vendoring or replacement.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.