paritytech / paritytech/host-rust-core

Enforce the review boundary by path

Open
#698 0 comments 0 reactions 1 assignee View on GitHub

@TarikGul is already working on this.

Since Sep 11, 2026.

host-work needs-decision
Dominant language
Swift
Stars
10
Forks
3
Avg merge
1d 10h
Merged PRs (30d)
148

Description

One repository holding the core and every host means one review queue unless scrutiny is
allocated deliberately. The shared core reaches every host at once, so a bad decision there
is expensive. A mistake in presentation is a contained bug on one screen of one platform.

The intent is that core paths get careful engineer review with the architecture agreed
before code is written, and presentation paths can move on lighter automated review.

This has to be mechanical, not cultural. The known failure mode is business logic
turning up in the areas that were only lightly reviewed, and a convention did not prevent
it. So: path-scoped ownership, review required on guarded paths, and CI that blocks a merge
when a guarded path is touched without it.

Which paths are guarded is a decision for the team, not something to infer, which is why
this is labelled for decision.

Steps
  • Agree which paths are guarded
  • Path-scoped ownership for those paths
  • Review required on guarded paths
  • CI blocks a merge when a guarded path is touched without the required review
Done when

Business logic cannot merge through a lightly reviewed path, enforced rather than observed
afterwards.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.