[Feat]: Share the pagination page-size limit across contracts
Open
Beginner friendly
Nobody has claimed this yet.
P2
- Dominant language
- Solidity
- Stars
- 4
- Forks
- 2
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 24
Description
Component
Other
Priority
P2
Summary
DotnsNameEscrow defines its own MAX_RELEASED_PAGE_SIZE and MAX_REFUND_PAGE_SIZE, both 200. DotnsConstants.MAX_PAGE_SIZE (200) now holds the shared page-size ceiling and backs the PoP controller's paginated reads. Point the escrow constants at DotnsConstants.MAX_PAGE_SIZE so the limit lives in one place rather than being repeated per contract.
Proposal
- Replace
DotnsNameEscrow.MAX_RELEASED_PAGE_SIZEandMAX_REFUND_PAGE_SIZEwithDotnsConstants.MAX_PAGE_SIZE. - Keep the value at
200, so there is no change to the enforced page size.
Acceptance criteria
- The escrow pagination bounds read from
DotnsConstants.MAX_PAGE_SIZE. - The enforced page size is unchanged.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DotnsNameEscrow and DotnsConstants, locating the two escrow pagination constants and the shared MAX_PAGE_SIZE definition. Point both escrow bounds at DotnsConstants.MAX_PAGE_SIZE, then verify the enforced page-size limit remains 200 and the contract tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 86/100