parcel-bundler / parcel-bundler/lightningcss
custom media are not replaced when a visitor returns the style sheet on StyleSheetExit
Open
Nobody has claimed this yet.
pending triage
- Dominant language
- Rust
- Stars
- 7.7k
- Forks
- 302
- PR merge metrics
- No merged PRs in 30d
Description
When you return the stylesheet in the StyleSheetExit part of a visitor, custom media are not replaced (like they are if you don't return anything). Is this expected behaviour?
Repro can be found here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction in main.js and compare the visitor behavior when StyleSheetExit returns the stylesheet with the behavior when it returns nothing. Trace how custom media replacement is applied in those two cases; done means the expected replacement behavior is confirmed or corrected for the returning-style-sheet case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript, rust
- Domain
- compilers, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100