parcel-bundler / parcel-bundler/lightningcss

(config question, not a bug) Config: default + Safari 14 support

Open
#718 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pending triage
Dominant language
Rust
Stars
7.7k
Forks
302
PR merge metrics
No merged PRs in 30d

Description

I have a hard time with configuration. I went ahead with the default config but found rendering bugs in older Safari. So I'd like to support Safari >= 14 in addition to the default config. How do I go about that?

Seems like if I specify Safari using browserlist, all the smart lightningcss defaults go out the window and I'm in charge. So in effect specifying a target Safari >= 14 all the other browser tweaks are gone. No matter how I played with the browser targets (like last 2 versions, not dead) I couldn't match the defaults (e.g. various vendor prefixes are gone.) And I have a hard time finding what these defaults are. I'd like to be able to say "you do you but also support old safari" and can't figure out how to do it. I tried the concept of Features but even if I turn off all the features I still don't get the result I need.

From my cursory understanding the support is setup based on browser version during build time plus additional feature tweaking. I'd love to update the former without losing the latter

BTW, the Safari parts I'd love to have back in the output are due to its lack of support for

  • width>=0 (as opposed to min-width: 0)
  • text-decoration shorthand, e.g. text-decoration: underline dashed (I need -webkit-text-decoration)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with scripts/build-prefixes.js, especially the browser-version setup around lines 33 and 160. Compare the default configuration with a Safari >=14 target and check how the feature tweaks and vendor-prefix decisions differ. Done means the configuration can add older Safari support while retaining the default compatibility behavior, including the requested prefixes.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, rust
Domain
build-system, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.