parcel-bundler / parcel-bundler/lightningcss

Improperly unprefixing -webkit-box-orient when in a @supports block

Open
#710 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
7.7k
Forks
302
PR merge metrics
No merged PRs in 30d

Description

v1.24.1 is now removing the -webkit- prefix from -webkit-box-orient. Compare the output from v1.24.0 to 1.24.1.

Input

@supports (
    (display: -webkit-box) and (-webkit-box-orient: vertical) and (-webkit-line-clamp: 3)
  ) {
  .foo {
    display: -webkit-box;
  -webkit-box-orient: vertical;
  -webkit-line-clamp: 3;
  }
}

1.24.0

@supports (display: -webkit-box) and ((-webkit-box-orient: vertical)) and (-webkit-line-clamp: 3) {
  .foo {
    -webkit-line-clamp: 3;
    -webkit-box-orient: vertical;
    display: -webkit-box;
  }
}

1.24.1

@supports (display: -webkit-box) and (box-orient: vertical) and (-webkit-line-clamp: 3) {
  .foo {
    -webkit-line-clamp: 3;
    -webkit-box-orient: vertical;
    display: -webkit-box;
  }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the provided CSS in the linked Lightning CSS playground and compare the v1.24.0 and v1.24.1 outputs. Trace the @supports transformation and ensure the completed behavior preserves -webkit-box-orient in the condition, matching the v1.24.0 output.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.