parcel-bundler / parcel-bundler/lightningcss
Switch from non-ASCII code point to non-ASCII ident code point
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7.7k
- Forks
- 302
- PR merge metrics
- No merged PRs in 30d
Description
In the CSS syntax, the list of allowed characters in an identifier has been narrowed down.
This is “an arcane detail that affects approximately no one”, but you may be one of the approximately no ones affected by this.
I’m also happy to make a PR to remediate this, tho I may need some assistance with adding tests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the linked logic in src/values/syntax.rs around lines 319-323 and compare its allowed identifier characters with the narrowed CSS syntax described in the issue. Add or update tests with maintainer guidance, and consider the work done when identifier parsing follows the non-ASCII identifier code-point rule.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, rust
- Domain
- compilers, web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100