parallaxsecond / parallaxsecond/rust-tss-esapi
Offset checking for Marshall and UnMarshall
Open
@ionut-arm is already working on this.
Since Jun 11, 2023.
- Dominant language
- Rust
- Stars
- 135
- Forks
- 80
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 5
Description
We should add length checking off the input buffers for the _offset version of the marshall and unmarshall trait operations. Currently these methods don't do any checking as to whether the input buffer is shorter than what would be needed to read or write from them.
The checks should be performed before any (un)marshalling calls are made, and should return WrongParamSize if the buffer is not long enough. This return code should also be documented on the trait methods.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.