pallets / pallets/quart

`abort` typing doesn't accept Response as a valid parameter

Open Beginner friendly
#200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.7k
Forks
206
PR merge metrics
No merged PRs in 30d

Description

https://github.com/pallets/quart/blob/77077bdf6ff63c7c4230241a9328cd1c89a94357/src/quart/helpers.py#L392

Passing a Response object to abort is valid, the typing should be corrected here

Environment:

  • Python version: N/A
  • Quart version: 0.18.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/quart/helpers.py around line 392 and inspect the abort parameter annotation and nearby type definitions. Confirm that passing a Response is supported at runtime, then update the typing so Response is accepted and verify the relevant type-checking or test checks available in the repository.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.