pallets / pallets/quart

Additional signal arguments

Open
#150 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.7k
Forks
206
PR merge metrics
No merged PRs in 30d

Description

...why the websocket_sent/websocket_received signal don't provide the app object as parameter ?
On top of tath, given websocket is a stateful protocol, I would have expected to have websocket_started signal providing a kind of id websocket connection id that is again provided with subsequent websocket_sent/websocket_received/websocket_finished signals 🤔

From https://github.com/pgjones/quart-trio/pull/1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the websocket_sent and websocket_received signal entry points and the referenced quart-trio pull request. Determine the intended app argument, websocket connection identifier, and websocket_started/websocket_finished lifecycle, then define the expected API behavior and tests before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.