pallets / pallets/click

Opinion: Arguments should not be required for Variadics

Open
#2,824 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

parsing
Dominant language
Python
Stars
17.7k
Forks
2.3k
Avg merge
1d 30m
Merged PRs (30d)
18

Description

Docs:

  • Arguments:
    If you come from argparse, you might be missing support for setting nargs to + to indicate that at least one argument is required.
    This is supported by setting required=True. However, this should not be used if you can avoid it as we believe scripts should gracefully degrade into becoming noops if a variadic argument is empty. The reason for this is that very often, scripts are invoked with wildcard inputs from the command line and they should not error out if the wildcard is empty.

Reasoning:
Beyond the reasoning stated, I don't know of any.

Feature unlocked: N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the Arguments documentation and the variadic argument behavior described here, including required=True and the argparse comparison. Clarify whether the proposal changes runtime semantics or only documents current guidance; done requires an agreed behavior and corresponding documentation and test scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.