pallets-eco / pallets-eco/flask-debugtoolbar
Debug/fix why test passes when debugtoolbar monkey patch disabled
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 978
- Forks
- 151
- PR merge metrics
- No merged PRs in 30d
Description
From @mattaw in https://github.com/flask-debugtoolbar/flask-debugtoolbar/issues/150#issuecomment-597976350:
I am concerned that the debugtoolbar testing through tox passes just fine if I comment out the monkeypatch completely so I will try to improve that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the test suite through tox with the debugtoolbar monkey patch disabled, as described in the linked context. Compare the resulting coverage and assertions with the patch enabled, then identify what test behavior should demonstrate that the monkey patch matters. Done means the tests reliably detect a missing or ineffective monkey patch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- flask, python
- Domain
- devtools, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100