pallets-eco / pallets-eco/flask-admin

Fix width (and check functionality) of mapbox search text input

Open
#2,471 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug SF python mini-sprint
Dominant language
Python
Stars
6.1k
Forks
1.6k
Avg merge
6d 14h
Merged PRs (30d)
1

Description

When MAPBOX_SEARCH is True, a text box is shown on any map widgets that presumably lets the user search for locations.

The search bar has some width: 50% styling that is taking the width from the window, so is totally broken (see images below): <input style="position: absolute; z-index: 9999; display: block; margin: -42px 0px 0px 10px; width: 50%;" class="pac-target-input" placeholder="Enter a location" autocomplete="off">

We should fix the styling on the search box.

If you pick this up, we should also review the functionality and make sure it actually works full stop.

image image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the MAPBOX_SEARCH setting and the map widget code that renders the search input. Check the input's width in each affected map widget and verify that location search works; the issue is done when the bar fits its widget and searches function correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.