palantir / palantir/tracing-java
span completion should not return the completed span
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 28
- Forks
- 20
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 15
Description
By returning the completed span we require execution to be traced regardless of whether it will be observed. We can avoid this additional work when tracing is not requested. The solution to #34 should cover this case.
Potential non-break (API bend?): completeSpan returns an optional of the completed span, we may be able to return an empty optional when the trace is not observed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the completeSpan implementation and issue #34, since the proposed solution is expected to cover this case. Done means completeSpan can return an empty optional when the trace is not observed, avoiding execution tracing that is not requested, with the API impact considered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100