palantir / palantir/python-compute-module
[bug] `RefreshingOauthToken` should not accept a `refresh_interval` > token expiry
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 15
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
If a user specifies an arbitrarily large refresh_interval for RefreshingOauthToken, that can lead to an expired token being used. This value should not be any greater than the expires_in value returned from the oauth call.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in compute_modules/auth/third_party.py at the RefreshingOauthToken implementation referenced by the issue. Inspect how refresh_interval and the OAuth response's expires_in value are handled, then verify the completed behavior with the repository's relevant tests. Done means an arbitrarily large refresh_interval cannot result in an expired token being used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100